Allow filtering of css classes for Nav items

[StrangeTech]

As per this discussion:

Active state for menu item for blog cpt post

@Louis, in the past we’ve used the nav_menu_css_class filter, we’ve tested this with Cwicly/FSE and it doesn’t work due to nav_menu_css_class relying on the “old” way of displaying nav menus. We quickly refactored our code to use wp_get_nav_menu_items and tested but it doesn’t seem to show classes added using this method. I had a quick look at the Cwicly codebase and can see the reason, based on how the classes for nav items are created. Please can you append the classes from wp_get_nav_menu_…

Following on from this feature request:

When viewing post pages, set the post archive page in the menu to current or current-menu-parent / current-menu-ancestor

Description: When visiting any page, if that page is in the menu it is set to the current page. Usually with post types, a desirable behaviour to ensure users know where they are within the site is the following: Viewing any post page will result in the post type archive page menu item being set to current (as if the post page was a child of the archive page menu item). In any cases where this didn’t happen automatically, using the standard WordPress menu we could use filters to ensure the…

And this previous thread:

@Louis

As for classes, I’m still hesitant on whether we should include them as well since there are quite a few default ones. Maybe a toggle in the menu block?

I have created this feature request for easier tracking of this specifically.

We really need to be able to set the current class on custom post type parent archives when viewing a post of that type. This will only be possible when Cwicly allows filtering of the classes.

[StrangeTech]

Given the upcoming 1.3 release I appreciate the focus is on that. I am just re-requesting this, as we have a website releasing this week and we can’t highlight certain menu items due to this issue so for us this is high priority.

Please take a look at adding this soon, thanks.

[StrangeTech]

@Louis, thanks again for all of the recent updates.

As this is the only major missing feature with no current workaround, I am just highlighting it again. Using the Nav block we really need more control over the css for each item, so we can fill in what is missing by default in WordPress with regards to highlighting certain hierarchical nav menu items.

We will really appreciate you including this when possible. Thank you!

[StrangeTech]

@Louis, The 1.3.2 release was fantastic. Now that you have made it so the WP menu css classes are being dynamically added we will be extremely grateful if you can also enable the filtering of css classes via wp_get_nav_menu_items.

Thanks!

[Louis]

Hello @StrangeTech,

At the risk of repeating myself, we retrieve menu items using wp_get_nav_menu_items. There is no necessity for us to enable filtering for this function as it is managed by WordPress.

Or am I missing something?

Cheers,

[StrangeTech]

@Louis

There is no necessity for us to enable filtering for this function as it is managed by WordPress.

Thank you for confirming @Louis. Looking at the Cwicly codebase I can see that it includes the classes as you rightly say, so technically this should work now - running our code it currently doesn’t, so I will investigate and confirm when I have isolated the cause of the issue.

The general structure of our code looks something like this:

function highlight_custom_posts_taxonomy_menu_items( $items ) {
    foreach ( $items as $key => $item ) {
		$item->classes = update_menu_item_classes($item->classes, $item);
    }

    return $items;
}

add_filter( 'wp_get_nav_menu_items', 'highlight_custom_posts_taxonomy_menu_items' );

The highlight_custom_posts_taxonomy_menu_items effectively returns the updated array of classes for each item. Let me know if we are not doing it correctly.

[StrangeTech]

@Louis, thanks again for all of your efforts.

Upon further testing I can confirm this now works, so it can be marked as done.

[StrangeTech]

@Araminta, just fully confirming that as of the latest Cwicly version this works perfectly now and can be marked as done.

[Louis]

Hello @StrangeTech,

Thanks for confirming that this is now working on your end!

Cheers,

[emanuelechiari]

Hi Steange Tech…. I’m still looking for a snippet that make a menu item active when a post of a determined category is displayed ( usually a cpt )
And good news in these days ?
Thanks

[StrangeTech]

@emanuelechiari

And good news in these days ?

Yes indeed, we have this working on multiple sites now - I will share a general solution here as soon as I have time, it has been a very very busy 2023 and 2024 is even more so!