Menu item dropdown classes are not added

[StrangeTech]

Description:

Continuing from:

Menu items custom classes don't work

As of 1.3.2 this is now implemented. I have tested and confirm it works. Thank you Cwicly team!

After more extensive testing on a live site including with 1.3.3, there appears to be a minor bug with this.

Menu classes from WordPress are now honoured, except for dropdown items.

Screenshots, screen recording, code snippet

In class-navmenu.php, in the dropdown link the classes for the item are not being added:

Example of elsewhere in the code where they are being added correctly:

This was one of the reasons I initially commented this wasn’t working, then when I saw the standard links working it seemed like it was an error in our code at first.

Hopefully this is an easy fix now.

Thanks again for all of the amazing work in 1.3.3.

Environment info

• WordPress version: 6.4
• Cwicly Plugin version: 1.3.3

[StrangeTech]

Amazing progress this week!

@Louis

Fix: Nav Menu block → missing WordPress classes for dropdown menus. By default, classes have been moved to the <li> element to keep consistency with the current class. See filtering → https://docs.cwicly.com/miscellaneous/filters#nav-menu-block-classes-position

Confirmed fixed - we now finally have fully working nav menus with the correct highlighting.

@Louis and the Cwicly team, sincerely, thank you so much for sorting this out, it has a huge positive influence to the quality of sites we are able to produce. These little professional touches make all the difference.

[Louis]

Hello @StrangeTech,

Thank you for all your input, generous shares and time on the forum
And thank you for pointing out this bug with the extra details.

I’ll be moving this thread to fixed, but please don’t hesitate to leave a reply if you still experience a related issue.

Cheers,