Upon further inspection, we have identified that the Copy Linked seems to be enabled by default, but is not highlighted.
To truly disable it (initially) and know it has been disabled visually, you have to first click it (disabling it), click it again (enabling and highlighting it) and then click it again (disabling it and un-highlighting it).
Also, as mentioned in the other post, the selected state is not discernible when using Top Toolbar (please see screenshots).
Where is the default for this configured so this can be switched off for all users?
In what context is it applied (per machine, per session, per site, per user)? (we have tested using the same WP user on the same site and the setting was toggled on for two team members and off for one)
This is incorrect. The Copy Linked feature is disabled by default. It would be helpful to know how you came to this assumption.
On a new installation, copy/pasting blocks does exactly what is expected when Copy Linked is disabled.
This is only true when dark mode is enabled. A fix will be issued for this in the next update.
As mentioned above, it is disabled by default.
The setting is persistent to WordPress users → applies to a user like most settings in Cwicly.
Perhaps this happens only on older installations, but we were able to replicate the described behaviour yesterday, so it is definitely an issue, even if not the intended behaviour.
I will attempt to replicate it again today and do a screen recording.
Thank you!
In this case there is definitely a bug, because yesterday both I and another team member were logged in to the same site with the same user at the same time and their Copy Linked was “on” even though it wasn’t highlighted (even in the editor toolbar) and mine was “off”.
We had to go through the steps I mentioned to get it “off” again for them.
I stand corrected, my sincere apologies.
Looking at the code it seems that I purposefully left this linked to local storage…
A new installation would have this toggled on “by default” if the browser’s user had previously specified it to be toggled on, if on the same domain etc.
Right, thanks for confirming, that explains most of what we saw.
So, the only issue is the highlighting of the selected state. When you have a chance to work on this for dark mode, please can you take a look at the default selection behaviour, as it appeared to not be highlighted (looked off, but was actually on).
It will be great to have this off by default or at least configurable via the role editor, as it could cause confusion and bugs for clients/editors if on.
Currently it is off by default, and only relies on the user’s local storage to tell whether or not Copy Linked blocks is enabled and should show the correct state.
What are your thoughts about moving this to be user persistent through WordPress?
I definitely think this makes most sense, here is my reasoning:
It is consistent with the other UI related settings
Allows it to be off or on by default per user and per role (if connected to role manager)
When a specific user has turned it off, I imagine they expect it to be off regardless of the machine/device they are on when they turned it off
I understand that in some usage scenarios it may be toggled frequently, at the same time, I believe the benefits of user persistence are of greater significance.
